[MCAPI-54] feat: add validation logic for zero boot volume case #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okozachenko1203
changed the title
Member
Author
|
recheck |
okozachenko1203
force-pushed
the
boot-vol-check
branch
from
c88c247 to
b891407
Compare
Member
Author
|
recheck |
1 similar comment
Member
|
recheck |
okozachenko1203
force-pushed
the
boot-vol-check
branch
2 times, most recently
from
b891407 to
59eb645
Compare
when both boot volume size and flavor's root_gb are zero, cluster node vm creation will be failed. This commit prevents cluster creation with such params.
okozachenko1203
force-pushed
the
boot-vol-check
branch
from
41930c7 to
de58474
Compare
Signed-off-by: okozachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when both boot volume size and flavor's root_gb are zero, cluster node vm creation will be failed.
This commit prevents cluster creation with such params.