Add address-sort-order to cluster config
#849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Mesterton-Gibbons <[email protected]>
Ensures the correct `InternalIP` is selected when trying to contact the node, even if multiple IP addresses are available (for example secondary NICs) Signed-off-by: Sam Mesterton-Gibbons <[email protected]>
Member
|
@samdbmg thanks for the awesome change, I do have a small concern: What will happen in the scenario where someone uses an existing fixed network, in this case, I believe (on a side note, we probably should really have a test for that, but slowly and surely) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
Adds
address-sort-orderto the Cloud Controller Manager config, set to the CIDR of the node subnet - this feature was added in v1.26.0.This causes that address to sort before any secondary NICs on the node, avoiding the problem of secondary Neutron ports being used when trying to get log output.
I've tested this in @andrewbonney's deployment and it solves the problem in #442 as a result (although I've not yet been able to run the unit tests locally, so I'm hoping CI has me covered!)