Fixing correct date being returned when global course is set to ID 1#17
Open
rhell4 wants to merge 1 commit intovfremaux:MOODLE_35_STABLEfrom
Open
Fixing correct date being returned when global course is set to ID 1#17rhell4 wants to merge 1 commit intovfremaux:MOODLE_35_STABLEfrom
rhell4 wants to merge 1 commit intovfremaux:MOODLE_35_STABLEfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes is_available() is called when the global COURSE var has an id of 1, for example calendar events or accessing the activity with a direct link. This means the activity isn't completely restricted.
I've extracted the course from the \core_availability\info passed and used it to get the correct course id while also falling back to the global COURSE if no course is passed down to get_reference_date().