Added support for relative paths for dumpTree #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfsfitvnm
reviewed
Mar 7, 2025
| * ```ts | ||
| * Il2Cpp.perform(() => { | ||
| * Il2Cpp.dumpTree(); | ||
| * }); | ||
| * ``` | ||
| */ | ||
| export function dumpTree(path?: string, ignoreAlreadyExistingDirectory: boolean = false): void { | ||
| if (path && !path?.startsWith("/")) path = `${Il2Cpp.application.dataPath!}/${path}`; |
There was a problem hiding this comment.
I'm afraid this is this not cross platform...
|
Hi, #605 has been implemented, please read: https://github.com/vfsfitvnm/frida-il2cpp-bridge/blob/d624db6f016a0a3f6ff9de7a7113ba743a34727e/README.md#dumping. I believe the new way of dumping is much better as have the most flexibility possible and opens up new features :) |
vfsfitvnm
force-pushed
the
master
branch
2 times, most recently
from
00e222b to
06c6284
Compare
|
I think the dumping function should be left for use in a custom agent for when additional things are needed for compatibility with an app. |
|
@namtacs would you elaborate? What do you mean with "additional things are needed for compatibility with an app"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured might as well.
Should close #602.