Skip to content

Better model_layer_list + qwen attention_type fix - #73

Merged
vgel merged 6 commits into
mainfrom
theia/layer-list-qwen-attn_type
Sep 23, 2025
Merged

Better model_layer_list + qwen attention_type fix#73
vgel merged 6 commits into
mainfrom
theia/layer-list-qwen-attn_type

Conversation

@vgel

@vgel vgel commented Sep 23, 2025

Copy link
Copy Markdown
Owner
  • Improves model_layer_list
    • Better search using named_modules()
    • Adds an override in case search fails (use model.repeng_layers = model.x.y.z.layers)
  • Pass through getattr on ControlModule to handle attention_type on qwen2 models
    • Fixes AttributeError: 'ControlModule' object has no attribute 'attention_type'
  • Adds more tests for layer list handling, and slow marking for the slow tests
  • Bump version to 0.5.0

Co-Authored-By: @wassname wassname@users.noreply.github.com
Co-Authored-By: @thiswillbeyourgithub 26625900+thiswillbeyourgithub@users.noreply.github.com

@wassname

Copy link
Copy Markdown
Contributor

Nice!

@vgel
vgel force-pushed the theia/layer-list-qwen-attn_type branch from 2e56a57 to 5c35e98 Compare September 23, 2025 23:34
@wassname

Copy link
Copy Markdown
Contributor

You could also consider making a new uv group for things like umap-learn uv add --group exp umap-learn

@vgel

vgel commented Sep 23, 2025

Copy link
Copy Markdown
Owner Author

You could also consider making a new uv group for things like umap-learn uv add --group exp umap-learn

Good idea!

@vgel
vgel merged commit 50fce9d into main Sep 23, 2025
5 checks passed
@vgel
vgel deleted the theia/layer-list-qwen-attn_type branch September 23, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants