Fix some Python bindings #223
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the Python bindings.
The
has_distancesfunctions overloaded a static function and another function, and it created errors with importing the bdsg module in Python. The statichas_distances, the one dealing with record_t, was renamed torecord_has_distances.The constructor for PackedPositionOverlay that took a hangle graph as input was missing because of the recent addition of an optional parameter which uses std::unordered_set. It was specifically excluded from the bindings in the
config.cfg. I think I've made it work by tweaking the binding hooks.This might not fix all the bindings but at least now we can use the PackedPositionOverlay in python, like: