Automatically generate pullbacks of non-linear constructors - #1286
Merged
Conversation
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
March 18, 2025 08:59
59a5574 to
773e916
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PetroZarytskyi
force-pushed
the
constr-diff
branch
2 times, most recently
from
March 18, 2025 10:00
4c6043e to
be84924
Compare
parth-07
reviewed
Mar 18, 2025
parth-07
reviewed
Mar 18, 2025
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
March 24, 2025 11:27
be84924 to
6561f19
Compare
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
April 3, 2025 08:22
6561f19 to
7019e21
Compare
PetroZarytskyi
marked this pull request as ready for review
April 3, 2025 08:23
PetroZarytskyi
force-pushed
the
constr-diff
branch
3 times, most recently
from
April 3, 2025 13:08
47f54c5 to
37d2d2c
Compare
Collaborator
Author
|
The commits about try stmts and lambdas fix crashes that arise from unsupported features. We attempt to differentiate them because we now differentiate all constructors, including the ones added in #1288 just to make sure they aren't differentiated. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PetroZarytskyi
force-pushed
the
constr-diff
branch
2 times, most recently
from
June 16, 2025 13:02
be24b01 to
0b9d263
Compare
PetroZarytskyi
force-pushed
the
constr-diff
branch
2 times, most recently
from
June 16, 2025 13:38
aa51eba to
e96b094
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
approved these changes
Jun 16, 2025
vgvassilev
left a comment
vgvassilev
left a comment
Owner
There was a problem hiding this comment.
LGTM. If that's the commit structure you'd like to keep go ahead and merge; otherwise fix it and merge.
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
June 17, 2025 13:16
fbfc097 to
a03f1ba
Compare
PetroZarytskyi
force-pushed
the
constr-diff
branch
3 times, most recently
from
June 17, 2025 17:32
50c43ad to
6aef646
Compare
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
June 17, 2025 20:42
4e15a3f to
8ee3d2e
Compare
PetroZarytskyi
force-pushed
the
constr-diff
branch
3 times, most recently
from
June 17, 2025 21:07
370c0b3 to
92ff102
Compare
This commit introduces automatically generating any constructor pullbacks when custom ones are not provided. This is the continuation of vgvassilev#1288, which only enabled automatic pullbacks of simple linear constructors.
PetroZarytskyi
force-pushed
the
constr-diff
branch
from
June 17, 2025 21:39
92ff102 to
f00bcc4
Compare
PetroZarytskyi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces automatically generating any constructor pullbacks when custom ones are not provided. This is the continuation of #1288, which only enabled automatic pullbacks of simple linear constructors.