Rework SetIsReq and overlay and combine them into a single function - #1424
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
The problem this PR solves is explained in detail in vgvassilev#1423. For short, when we set vars to `used`/`unused` in TBR, we handle constant array indices (like `arr[3]`) in `TBR::SetIsRequired` and partly cover the gaps in the logic in `TBR::overlay`. This PR moves handling of all cases to `TBR::SetIsRequired` and fixes the bug in vgvassilev#1423. Also, this PR removes the state variable `TBR::m_NonConstIndexFound` that was used to detect the cases when `TBR::overlay` should be called. Apart from that, `ProfileID` sequences are now reversed to the right order for easier handling: the sequence of `arr[2].k` used to be `{k, 2}` and is now `{2, k}`. Iterating backwards through the sequence in recursion resulted in code that was quite hard to read. Fixes vgvassilev#1423
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem this PR solves is explained in detail in #1423. For short, when we set vars to
used/unusedin TBR, we handle constant array indices (likearr[3]) inTBR::SetIsRequiredand partly cover the gaps in the logic inTBR::overlay. This PR moves handling of all cases toTBR::SetIsRequiredand fixes the bug in #1423. Also, this PR removes the state variableTBR::m_NonConstIndexFoundthat was used to detect the cases whenTBR::overlayshould be called.Apart from that,
ProfileIDsequences are now reversed to the right order for easier handling: the sequence ofarr[2].kused to be{k, 2}and is now{2, k}. Iterating backwards through the sequence in recursion resulted in code that was quite hard to read.Fixes #1423