Fix #1539 Use parallelism in clad::restore_tracker #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-07
reviewed
Nov 30, 2025
| } | ||
|
|
||
| // Parallel restore | ||
| std::for_each(std::execution::par, work.begin(), work.end(), |
Collaborator
There was a problem hiding this comment.
Can't we directly use for_each on m_data instead of copying the elements to a vector?
Author
There was a problem hiding this comment.
Seems like github ci doesn't support (c++ 17)
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Enable clad after the header was included. | ||
| // FIXME: The header inclusion should be made automatic if the pragma is seen. | ||
| #pragma clad ON | ||
| #pragma clad ON No newline at end of file |
Contributor
There was a problem hiding this comment.
warning: unknown pragma ignored [clang-diagnostic-unknown-pragmas]
#pragma clad ON
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1539.
I have used c++ 17 feature
std::execution::parto make execution of loop parellel. For efficient execution of threads I have used separate array. This was existing function so no tests were written.Any external dependency introduced?
I have used standard c++ includes so no new dependency