Fix CUDA global argument detection for aliased kernel parameters - #1843
Open
MdSaifAliMolla wants to merge 1 commit into
Open
Fix CUDA global argument detection for aliased kernel parameters#1843MdSaifAliMolla wants to merge 1 commit into
MdSaifAliMolla wants to merge 1 commit into
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
MdSaifAliMolla
marked this pull request as draft
June 22, 2026 09:06
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes vgvassilev#1623. DiffPlanner and ReverseModeVisitor disagreed on CUDAGlobalArgsIndexes for aliased args like add(a, a).
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
MdSaifAliMolla
marked this pull request as ready for review
June 26, 2026 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1623 and
as they are related, I believe.