[ci] Run the valgrind job against clang-20 and runtime 22. - #1850
Open
vgvassilev wants to merge 2 commits into
Open
[ci] Run the valgrind job against clang-20 and runtime 22.#1850vgvassilev wants to merge 2 commits into
vgvassilev wants to merge 2 commits into
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
The valgrind row trailed the support window at clang-19 / runtime 20. Bump it to clang-20 / runtime 22 so memory checking tracks the newest supported toolchain, matching the existing ubu24-clang20-runtime22 row.
Nearly fifty tests carried XFAIL: valgrind, which hid every memcheck result for them -- both clad's own (now-fixed) leaks and clang's uninitialised-value false positives in its own type machinery. A blanket expected-failure also flips to an XPASS the moment the underlying noise is suppressed, so it can no longer tell a real regression from a stale marker. Remove the markers so the refreshed clang-20 / runtime 22 valgrind row reports each test's actual state; genuine clang-internal noise is better handled with a targeted suppression file than by silencing whole tests.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.