Remove the unused StmtClone clone mapping. NFC - #1910
Merged
Conversation
StmtCloneMapping recorded, for each cloned Stmt and VarDecl, the original it came from. Nothing ever read either map, and no caller passed a mapping in the first place -- the sole StmtClone is constructed without one -- so m_OriginalToClonedStmts was permanently null and both writes were dead. Drop the struct, the member, the typedefs and the two writes. Cloning that must remap references to its clones does so through m_DeclReplacements, which the callers already maintain.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StmtCloneMapping recorded, for each cloned Stmt and VarDecl, the original it came from. Nothing ever read either map, and no caller passed a mapping in the first place -- the sole StmtClone is constructed without one -- so m_OriginalToClonedStmts was permanently null and both writes were dead.
Drop the struct, the member, the typedefs and the two writes. Cloning that must remap references to its clones does so through m_DeclReplacements, which the callers already maintain.