[CI] Give push events a unique concurrency group - #1920
Merged
Conversation
The concurrency group keys on github.event.pull_request.number, which is set only for pull_request events. On a push to master that expression is empty, so every master push collapses into one group and, with cancel-in-progress, each new push cancels the previous run mid-flight. The self-hosted coverage row (wake-on-lan, then a CUDA + Enzyme + sanitizer build) is by far the slowest job, so on master it is almost always cancelled before the codecov upload step runs. Master never gets a base coverage report, and every PR's codecov/project status -- which uses `target: auto` and needs the base coverage -- stalls at "Expected -- Waiting" indefinitely. codecov/patch is unaffected: it needs only the PR's own report. Fall back to github.sha when there is no PR number, so each pushed commit gets its own group and push runs stop cancelling each other.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concurrency group keys on github.event.pull_request.number, which is set only for pull_request events. On a push to master that expression is empty, so every master push collapses into one group and, with cancel-in-progress, each new push cancels the previous run mid-flight.