Fix uninitialized record assignment in reverse mode - #1938
Open
Elvand-Lie wants to merge 1 commit into
Open
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vgvassilev
reviewed
Aug 2, 2026
| auto grad = clad::gradient(fn); | ||
| } | ||
|
|
||
| // CHECK-LABEL: void fn_grad |
Owner
There was a problem hiding this comment.
Why not using CHECK: and CHECK-NEXT? We also need to check the execution results.
Contributor
Author
There was a problem hiding this comment.
Updated in a9fe9a5. The regression now uses CHECK/CHECK-NEXT for the generated loop, builds and runs the test executable, and checks the derivative result (6.00) with CHECK-EXEC. I also verified that the revised lit test passes with this patch and fails against current origin/master at the original s = ; line.
Elvand-Lie
force-pushed
the
fix-1283-loop-record-initialization
branch
from
August 2, 2026 17:04
1f545c6 to
a9fe9a5
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
origin/masterand passes with this changeorigin/masterDifferentiatorHTestsandMiscTests: 5/5 passedgit-clang-format-18: no changesclang-tidy-18on the changed production-code range: no diagnosticsgit diff --checkFixes: #1283