Skip to content

Conversation

@micheal-parks
Copy link
Collaborator

Two fixes here:

  • clear up entities when executing remove draw calls
  • correct reparenting when editing frames

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 4c251b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

{/if}
{/if}

<T
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only removed portal here

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/components/Geometry2.svelte 0.00% 54 Missing ⚠️
src/lib/components/Frame.svelte 0.00% 15 Missing ⚠️
src/lib/hooks/useDrawAPI.svelte.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!


<T.Group attach={focusedObject ? false : undefined}>
<T.Group
name="world-root"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this name?

@micheal-parks micheal-parks merged commit ae47b1c into main Dec 18, 2025
5 checks passed
@micheal-parks micheal-parks deleted the parenting-fix branch December 18, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants