Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3417: Make web app sample show a video stream instead of image #4152

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

JessamyT
Copy link
Collaborator

No description provided.

@JessamyT JessamyT requested a review from kharijarrett March 26, 2025 20:24
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Mar 26, 2025
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 3616caa
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67e4627fb0e21a0008759c22
😎 Deploy Preview https://deploy-preview-4152--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29 (🔴 down 20 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JessamyT JessamyT requested review from micheal-parks and removed request for kharijarrett March 26, 2025 21:03
@JessamyT JessamyT changed the title DOCS-3417: Make sample show a video stream instead of image DOCS-3417: Make web app sample show a video stream instead of image Mar 26, 2025
Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for updating!

Copy link
Member

@micheal-parks micheal-parks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

in the future it might be cool to use the new svelte sdk or react sdk (whenever it gets built) since it makes this much easier to work with

@JessamyT
Copy link
Collaborator Author

Ah okay I'll make a ticket to do that! Would you recommend one over the other for any reason @micheal-parks ? (assuming I wait till react gets built)

@JessamyT JessamyT merged commit b91c060 into viamrobotics:main Mar 28, 2025
13 checks passed
@JessamyT JessamyT deleted the 3417stream branch March 28, 2025 17:34
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants