RSDK-10142 - Add relative (normalized) bounding boxes to RDK #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
penguinland
approved these changes
Mar 31, 2025
| // NewNormalizedBoundingBox creates a normalized bounding box from the image bounds and the bounding box. | ||
| func NewNormalizedBoundingBox(imageBounds, boundingBox image.Rectangle) []float64 { | ||
| if imageBounds.Max.X == 0 || imageBounds.Max.Y == 0 { | ||
| return nil |
There was a problem hiding this comment.
I appreciate the caution here, but can't think of a situation in which we'd hit this line. Is it worth logging a giant warning about how we've encountered impossible data? Maybe not; just a thought.
viambot
added
safe to test
|
Tested on Mac with Python SDK script and am able to get all the normalized box values from the mlvision vision service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we're adding normalized bounding boxes to RDK by incorporating it into our idea of a "Detection". I've edited the Detection constructor to take in the image bounds so the calculations can happen. See scope: (https://docs.google.com/document/d/1cezhhCrPOi6ANjo7laOZ_CBzvZxi7Ea4zx3qgrolwks/edit?tab=t.0#heading=h.tcicyojyqi6c)
I've also included a "no img bounds" constructor. Server and client side code were updated and tests were updated as well to include/test the new changes.