Skip to content

RSDK-10618: Fix data race when modules crashes during reconfiguration #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

RSDK-10618: Fix data race when modules crashes during reconfiguration #4975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5ffed00
Break deadlock when a module tries to restart while being reconfigured
jmatth May 6, 2025
4917724
Removing redundant synchronization code
jmatth May 7, 2025
9092dcd
Refactoring module struct into a separate file
jmatth May 8, 2025
160193c
Properly handle mutex handoff in unexpected restart callback
jmatth May 9, 2025
0317869
Fixing test that still referenced removed struct field
jmatth May 9, 2025
b340efa
Removing use of new type alias from pexec so CI can run
jmatth May 9, 2025
0c47dc1
Wait on module processes to terminate in test cleanup
jmatth May 9, 2025
7d598f8
Removing unused method and formatting code to keep the linter happy
jmatth May 9, 2025
82f10c0
Bump goutils
jmatth May 13, 2025
e59d45e
Clean up duplicate goutils entry in go.mod
jmatth May 13, 2025
1739ef0
Merge remote-tracking branch 'upstream/main' into RSDK-10618
jmatth May 14, 2025
3f1a858
Fixing race in server shutdown test
jmatth May 14, 2025
40f7452
Make docstring linter happy
jmatth May 14, 2025
1e799ed
Preventing crashed module restart when module has been removed
jmatth May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ require (
go.uber.org/zap v1.27.0
go.viam.com/api v0.1.434
go.viam.com/test v1.2.4
go.viam.com/utils v0.1.142
go.viam.com/utils v0.1.143
goji.io v2.0.2+incompatible
golang.org/x/image v0.19.0
golang.org/x/mobile v0.0.0-20240112133503-c713f31d574b
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,8 +1536,8 @@ go.viam.com/api v0.1.434 h1:4dC9apRVF0SjPZ5w7BjISPZLCoiYqfFMIdmPOygNNWs=
go.viam.com/api v0.1.434/go.mod h1:gwJriv6EVWe97uFzzzWjzP3NPfpCrKtRAdWtYglUpqs=
go.viam.com/test v1.2.4 h1:JYgZhsuGAQ8sL9jWkziAXN9VJJiKbjoi9BsO33TW3ug=
go.viam.com/test v1.2.4/go.mod h1:zI2xzosHdqXAJ/kFqcN+OIF78kQuTV2nIhGZ8EzvaJI=
go.viam.com/utils v0.1.142 h1:vk5ijKf5Q2eZ1AOOOttAhmLG1IHxGm+nrgz5j/CkvtA=
go.viam.com/utils v0.1.142/go.mod h1:AjmP/wKHvMkBBW55HJecD3I3Ci10vZGFv7RzFfJ6+mw=
go.viam.com/utils v0.1.143 h1:QyvniQw6+WDovfyhMzbDO6D2vPkiQpKyDkjDPu1OaE0=
go.viam.com/utils v0.1.143/go.mod h1:AjmP/wKHvMkBBW55HJecD3I3Ci10vZGFv7RzFfJ6+mw=
go4.org/unsafe/assume-no-moving-gc v0.0.0-20230525183740-e7c30c78aeb2 h1:WJhcL4p+YeDxmZWg141nRm7XC8IDmhz7lk5GpadO1Sg=
go4.org/unsafe/assume-no-moving-gc v0.0.0-20230525183740-e7c30c78aeb2/go.mod h1:FftLjUGFEDu5k8lt0ddY+HcrH/qU/0qk+H8j9/nTl3E=
gocv.io/x/gocv v0.25.0/go.mod h1:Rar2PS6DV+T4FL+PM535EImD/h13hGVaHhnCu1xarBs=
Expand Down
Loading
Loading