remove-gostream-dep-on-mediadevices #4983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
nicksanford
commented
May 12, 2025
Comment on lines
-365
to
-370
| for _, label := range labels { | ||
| if label == target { | ||
| return true | ||
| } | ||
| } | ||
| return false |
nicksanford
commented
May 12, 2025
Comment on lines
-379
to
-385
| labels := strings.Split(d.Info().Label, camera.LabelSeparator) | ||
| for _, label := range labels { | ||
| if labelPattern.MatchString(label) { | ||
| return true | ||
| } | ||
| } | ||
| return false |
nicksanford
commented
May 12, 2025
Comment on lines
-30
to
-32
| constraint.Width = prop.IntRanged{640, 4096, 1920} | ||
| constraint.Height = prop.IntRanged{400, 2160, 1080} | ||
| constraint.FrameRate = prop.FloatRanged{0, 200, 60} |
abe-winter
approved these changes
May 12, 2025
seanavery
approved these changes
May 12, 2025
|
@nicksanford Have we verified that using camera package from RDK no longer includes mediadevices as a dependency? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mediadevices's camera driver's init function, defined in camera_PLATFORM.go, runs C code within it's init() function that tries to discover webcams but doesn't always work on all platforms, sometimes causing the OS process to crash:
https://github.com/pion/mediadevices/blob/v0.6.4/pkg/driver/camera/camera_linux.go
https://github.com/pion/mediadevices/blob/v0.6.4/pkg/driver/camera/camera_darwin.go
https://github.com/pion/mediadevices/blob/v0.6.4/pkg/driver/camera/camera_windows.go
Currently, any module that has a transitive dependency on the RDK camera interface also depends on gostream, and as a consequence, will execute the media devices camera driver's init function on os process startup.
This is completely unnecessary as the only reason why gostream depended on mediadevices is to import a constant.
This code change removes the gostream -> mediadevices dependency, reducing the times when module implementers will unexpectedly.
Long term, we should consider removing the dependency on mediadevices altogether by moving the builtin webcam camera to a module.