RSDK-10518: Support setting globalLogger's level from config file #4984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the configuration file:
"debug": true
or
"log": [ { "pattern": "*", "level": "debug", } ]
will now display DEBUG logs for modules. Note the latter updates through
config.go:UpdateLoggerRegistryFromConfig
and appears to work fine as-is.Currently, this is only available when running
viam-server
with-debug
because:RunServer
calls config.InitLoggingSettings(logger, argsParsed.Debug):InitLoggingSettings calls both
logging.GlobalLogLevel.SetLevel
andlogger.SetLevel
.The
refreshLogLevelInLock
is called after configs are read (both initially and when updated) and is missing thelogger.SetLevel
update.