Skip to content

Update dependencies comment in generated modules #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

JessamyT
Copy link
Contributor

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 21, 2025
@JessamyT JessamyT requested a review from benjirewis May 21, 2025 23:12
@JessamyT JessamyT changed the title Update dependencies comment Update dependencies comment in generated modules May 21, 2025
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we getting rid of the "implicit/explicit" distinction in docs? I think we should and only present the concept of "required/optional" to users (no references to depends_on).

@JessamyT
Copy link
Contributor Author

Are we getting rid of the "implicit/explicit" distinction in docs? I think we should and only present the concept of "required/optional" to users (no references to depends_on).

Yes :) In viamrobotics/docs#4309 I moved the already-deprecated reference to explicit dependencies out of the module dependencies page and into the changelog. Big fan of removing that terminology from users' eyeballs, since it was confusing to begin with!

@JessamyT JessamyT merged commit 966a40c into viamrobotics:main May 22, 2025
18 checks passed
@JessamyT JessamyT deleted the implicitexplicit branch May 22, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants