Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-10123] User defined metadata crud apis #345

Closed
wants to merge 11 commits into from

Conversation

JosephBorodach
Copy link
Member

Description

Add user-defined metadata CRUD operations

See ticket here

Todo

  • Do I need to manually test?

@JosephBorodach JosephBorodach requested a review from a team as a code owner March 5, 2025 16:56
@JosephBorodach JosephBorodach force-pushed the RSDK-10127-User-Defined-Metadata branch 2 times, most recently from e776466 to c8a0cb2 Compare March 5, 2025 17:05
@JosephBorodach JosephBorodach force-pushed the RSDK-10127-User-Defined-Metadata branch from c8a0cb2 to 3a9e90e Compare March 5, 2025 17:10
@JosephBorodach JosephBorodach force-pushed the RSDK-10127-User-Defined-Metadata branch from a005795 to 637eec6 Compare March 6, 2025 14:50
@JosephBorodach
Copy link
Member Author

[q] @njooma - Do you have any idea how I am supposed to resolve that lint issue? It says to run make format - is that correct? When I run that command it changes close to a 100 files.

@JosephBorodach JosephBorodach requested review from njooma and removed request for njooma March 6, 2025 15:18
@stuqdog
Copy link
Member

stuqdog commented Mar 6, 2025

[q] @njooma - Do you have any idea how I am supposed to resolve that lint issue? It says to run make format - is that correct? When I run that command it changes close to a 100 files.

@JosephBorodach not to doubt you but just to confirm: are you actually seeing 100 files being changed? When I run make format on your branch I see the line Formatted 171 files (2 changed) in 0.57 seconds., and only the two files you touched are actually changed.

Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per typescript PR, I'd recommend having the update{Foo}Metadata methods return void rather than their empty response types. Otherwise lgtm!

@JosephBorodach
Copy link
Member Author

Per typescript PR, I'd recommend having the update{Foo}Metadata methods return void rather than their empty response types. Otherwise lgtm!

Funny enough I was pushing that change as you commented! Thanks again for calling this out!

@JosephBorodach
Copy link
Member Author

JosephBorodach commented Mar 6, 2025

[q] @njooma - Do you have any idea how I am supposed to resolve that lint issue? It says to run make format - is that correct? When I run that command it changes close to a 100 files.

@JosephBorodach not to doubt you but just to confirm: are you actually seeing 100 files being changed? When I run make format on your branch I see the line Formatted 171 files (2 changed) in 0.57 seconds., and only the two files you touched are actually changed.

@stuqdog - It's totally possible (probably even likely because I am very unfamiliar with the sdks and flutter) but git seems to be saying the files we actually modified. Are you seeing something different?
Screenshot 2025-03-06 at 10 25 28 AM

@stuqdog
Copy link
Member

stuqdog commented Mar 6, 2025

@JosephBorodach Huh that's strange, that's definitely not what I'm seeing! I'm sending you a diff on slack, you should be able to just git apply it locally and then push that to fix this.

@JosephBorodach JosephBorodach force-pushed the RSDK-10127-User-Defined-Metadata branch from bc03973 to 004d005 Compare March 6, 2025 19:02
@njooma njooma self-requested a review March 12, 2025 16:09
@JosephBorodach
Copy link
Member Author

This pr was replaced by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants