-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-10123] User defined metadata crud apis #345
Conversation
e776466
to
c8a0cb2
Compare
c8a0cb2
to
3a9e90e
Compare
a005795
to
637eec6
Compare
[q] @njooma - Do you have any idea how I am supposed to resolve that lint issue? It says to run |
@JosephBorodach not to doubt you but just to confirm: are you actually seeing 100 files being changed? When I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per typescript PR, I'd recommend having the update{Foo}Metadata
methods return void rather than their empty response types. Otherwise lgtm!
Funny enough I was pushing that change as you commented! Thanks again for calling this out! |
@stuqdog - It's totally possible (probably even likely because I am very unfamiliar with the sdks and flutter) but git seems to be saying the files we actually modified. Are you seeing something different? |
@JosephBorodach Huh that's strange, that's definitely not what I'm seeing! I'm sending you a diff on slack, you should be able to just |
bc03973
to
004d005
Compare
…matting lint issue
This pr was replaced by this |
Description
Add user-defined metadata CRUD operations
See ticket here
Todo