Skip to content

Remove deprecated things#833

Merged
rcannood merged 6 commits into
port_integers_as_doublesfrom
deprecate_things
Jun 11, 2025
Merged

Remove deprecated things#833
rcannood merged 6 commits into
port_integers_as_doublesfrom
deprecate_things

Conversation

@rcannood
Copy link
Copy Markdown
Contributor

@rcannood rcannood commented Jun 11, 2025 •
edited
Loading

Describe your changes

  • Deprecate .functionality
  • Deprecate .platforms
  • Deprecate .runner[.type == "docker"].image, .registry, .tag
  • Deprecate channelFromParams(...)

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@rcannood rcannood changed the title Deprecate_things Remove deprecated things Jun 11, 2025
hcannoodt
hcannoodt approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hcannoodt hcannoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@rcannood rcannood requested a review from hcannoodt June 11, 2025 20:27
hcannoodt
hcannoodt approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hcannoodt hcannoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking even better!

@rcannood rcannood merged commit 60400a6 into port_integers_as_doubles Jun 11, 2025
7 checks passed
@rcannood rcannood deleted the deprecate_things branch June 11, 2025 20:44
rcannood pushed a commit that referenced this pull request Jun 12, 2025
@hcannoodt @danielskatz
Port Nextflow fix, Bump Viash version, Remove deprecated functionality (
fe0e266 
#832)

* Fix author names in paper (#644)

* add paper

* update paper

* add more orcids

* move figures

* rename pipeline to workflow

* add section on benefits

* rewrite state of the field

* solve issue with figure 3

* update bibtex

* update bibtex again

* broaden domain

* update figure 2 based on @wilkinson's feedback

* minor changes in paper (#628)

* minor change

* fix refactoring error

* Add JOSS release info

* update readme

* Fix author names

---------

Co-authored-by: Daniel S. Katz <d.katz@ieee.org>

* use reflection to get viash to fix issue in nextflow edge (#812)

* use reflection to get viash to fix issue in nextflow edge

* add entry to changelog

* Backport: Make sure scripts in Nextflow have the right extension (#815)

* Backport: Make sure scripts in Nextflow have the right extension

* fix changelog

* Edit -- I'm going to port it in the different direction

* Pass session as an argument (#818)

* pass session as an argument

* fix import

* Prepare for release

* post release changes, update release guide

* Add entry for 0.8.7

* port of #823

* add pr number

* copied 0.8.8 changelog entry

* update version and changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

* post release changes

* cherry pick 5271a3b

* fix test

* Remove deprecated things (#833)

* wip deprecate things

* fix components

* fix test

* update tests and yamls

* fix test (recent versions of git require a message)

* remove test code for removed functionality

* Update CHANGELOG.md

---------

Co-authored-by: Hendrik Cannoodt <hendrik.cannoodt@gmail.com>
Co-authored-by: Daniel S. Katz <d.katz@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hcannoodt hcannoodt hcannoodt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcannood @hcannoodt