Skip to content

Fix/gha failing (#861)#862

Merged
rcannood merged 1 commit into
develop_0_9from
gha_failing_develop_0_9
Dec 1, 2025
Merged

Fix/gha failing (#861)#862
rcannood merged 1 commit into
develop_0_9from
gha_failing_develop_0_9

Conversation

@hcannoodt
Copy link
Copy Markdown
Collaborator

@hcannoodt hcannoodt commented Dec 1, 2025

Describe your changes

apply fix from main in develop_0_9 too

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@hcannoodt
Fix/gha failing (#861)
e1a7bdb 
* output checkDockerImageExists results as it seems to be the common factor

* allow ':' in docker images output

* disable print again, but keep it as println. print was pretty much unreadable.
@hcannoodt hcannoodt requested a review from rcannood December 1, 2025 08:02
rcannood
rcannood approved these changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit bbb643a into develop_0_9 Dec 1, 2025
7 checks passed
@hcannoodt hcannoodt deleted the gha_failing_develop_0_9 branch December 1, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rcannood rcannood rcannood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hcannoodt @rcannood