Skip to content

add 'pull_request' to the ns_test and sbt_test workflow triggers#866

Merged
hcannoodt merged 4 commits into
mainfrom
fix/external_pr_workflows
Feb 6, 2026
Merged

add 'pull_request' to the ns_test and sbt_test workflow triggers#866
hcannoodt merged 4 commits into
mainfrom
fix/external_pr_workflows

Conversation

@hcannoodt
Copy link
Copy Markdown
Collaborator

Describe your changes

Run tests on PR creation.
Only running on push isn't enough when dealing with PRs from forks.

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Copy link
Copy Markdown
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question

Comment thread .github/workflows/ns_test.yml Outdated
Comment thread .github/workflows/sbt_test.yml Outdated
hcannoodt and others added 2 commits February 6, 2026 11:16
Co-authored-by: Robrecht Cannoodt <robrecht@data-intuitive.com>
Co-authored-by: Robrecht Cannoodt <robrecht@data-intuitive.com>
@hcannoodt hcannoodt merged commit a1078a3 into main Feb 6, 2026
7 checks passed
@hcannoodt hcannoodt deleted the fix/external_pr_workflows branch February 6, 2026 10:52
lazappi pushed a commit that referenced this pull request May 13, 2026
* add 'pull_request' to the ns_test and sbt_test workflow triggers

* reduce the amount of duplicate tests

* Apply suggestion from @rcannood

Co-authored-by: Robrecht Cannoodt <robrecht@data-intuitive.com>

* Apply suggestion from @rcannood

Co-authored-by: Robrecht Cannoodt <robrecht@data-intuitive.com>

---------

Co-authored-by: Robrecht Cannoodt <robrecht@data-intuitive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants