Improved bash json parser#869
Merged
Merged
Conversation
hcannoodt
approved these changes
Feb 10, 2026
Collaborator
hcannoodt
left a comment
There was a problem hiding this comment.
it's starting to become all a bit crazy ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rewrites the Bash JSON parser (
ViashParseJson.sh) as a recursive descent parser modelled after the ScalaViashParseJson.scala. The old line-based regex parser silently failed on compact JSON and had fragile string/array handling.Related issue(s)
Part of the
switch_to_arraysbranch (PR #762).Type of Change
Changes
Problems with the old parser:
New parser: Recursive descent with
_viash_peek/_viash_consumeprimitives, type-specific parsers (_viash_parse_string,_viash_parse_number, etc.), serialization functions for deep nesting, and proper error reporting. Input is pre-split into a character array viafold -w1for O(1) access.Performance:
Compatibility
declare -g,local -n, orreadarrayChecklist