Conversation
…ations process.rs: - Shared kill_port() used by both CLI and API - SIGTERM → poll every 100ms with ps -p (EPERM-safe) → SIGKILL after 2s - Tracks original PIDs to avoid killing replacement processes - find_listeners returns Result (surfaces lsof failures) - pid_exists uses ps -p (ownership-independent, not kill -0) - KillResult: Killed, ForceKilled, NotFound, Error - ForceKilled only when kill -9 actually succeeds - Error when process is still alive but unkillable (EPERM) - 6 tests covering find_listeners, pid_exists, kill flow ports.rs: - merge_alive() for combining TCP scan + container ports - Replaces 4 duplicated merge loops across scanner, handlers, and CLI template.rs: - Toast notifications for kill and unregister actions - Success/error toasts with auto-dismiss after 3s Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGTERM not always sufficient, so implement SIGKILL to fix stuff like this: https://x.com/samuelcolvin/status/2039112941316796582