special exception for connection errors in libevent#1469
Open
yannick wants to merge 2 commits into
Open
Conversation
Contributor
|
@s-ludwig no comment? |
Member
|
Having proper separate exception types is definitely a pressing issue for the library in general. The problem is that it is going to be very difficult to switch from a custom exception hierarchy to exceptions defined in Phobos once they become available. However, if the depth of the hiearchy within vibe.d is kept to 1 and all those exception classes are marked final, it should be possible without breaking normal user code. In this case, the question is if this should derive from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ideas here:
a) make the errors catchable so it can be ignored or more silently logged
b) add some information about the peer if possible.
PR is probably not usable as is, but i want to discuss the Idea.
reason: i see lots of such errors in production (mainly from mobile ios devices):
(this is with below PR already included)