Conversation
Add --connect-timeout 15 --max-time 300 to all 3 curl download commands in install.sh (lines 438, 842, 843). Without these flags, the installer hangs indefinitely on flaky networks or DNS issues with no feedback. Timeouts chosen: - --connect-timeout 15: allow 15s for TCP handshake (generous for slow networks) - --max-time 300: 5 min total per download (sufficient for large binaries)
Esc1200
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--connect-timeout 15 --max-time 300to all 3curldownload commands ininstall.sh(lines 438, 842, 843).Problem
Without timeout flags, the installer hangs indefinitely on flaky networks or DNS issues with zero feedback to the user. There are 3 active
curldownload commands in the file and none had any timeout configured.Fix
curl -fsSL --connect-timeout 15 --max-time 300 ...curl -fsSL --connect-timeout 15 --max-time 300 ...curl -fsSL --connect-timeout 15 --max-time 300 ...Timeout values
--connect-timeout 15: 15 seconds for TCP handshake — generous enough for slow/mobile networks--max-time 300: 5 minutes total per download — sufficient for large binaries like Node tarballsSeverity
MEDIUM — installer hangs silently on network issues, leaving users stuck with no actionable error.
Testing
Packet: spark-compete-hotfix-v1
Team: drophub_sir (Esc1200)
PR Author: Esc1200
Repo: vibeforge1111/Spark-Agent-Site
Actual behavior: All 3 curl commands in install.sh lack timeout flags, hanging indefinitely on network failures.
Expected behavior: curl commands should have --connect-timeout and --max-time flags for bounded failure time.
Repro steps: Run install.sh on a network with intermittent connectivity or blocked DNS; observe indefinite hang at lines 438, 842, or 843.
Before/after proof: Before:
curl -fsSL "$url" -o "$archive". After:curl -fsSL --connect-timeout 15 --max-time 300 "$url" -o "$archive".Tests/smoke: Verified diff shows exactly 3 lines changed. On network failure, curl exits with error code 28 (timeout) after 15s or 300s instead of hanging.
Duplicate notes: No prior PR found adding timeout flags to curl commands in install.sh.
Risk notes: Minimal risk — only adds standard curl timeout flags. No change to download URLs, verification logic, or successful-path behavior.
Review claim: pr_review