Skip to content

Fix pointers event in windy mobile UI#374

Merged
vicb merged 3 commits intomasterfrom
vicb/windy-pointers
Sep 11, 2025
Merged

Fix pointers event in windy mobile UI#374
vicb merged 3 commits intomasterfrom
vicb/windy-pointers

Conversation

@vicb
Copy link
Copy Markdown
Owner

@vicb vicb commented Sep 11, 2025

Summary by Sourcery

Enable pointer events for the Windy sounding plugin on mobile devices and bump version to 4.1.15

Bug Fixes:

  • Restore pointer-events on the plugin content in mobile UI to re-enable interactions

Build:

  • Bump windy-plugin-fxc-soundings version to 4.1.15

Summary by CodeRabbit

  • Bug Fixes

    • Restored touch interactions for the Windy Sounding plugin on mobile devices, enabling taps and other gestures within the plugin content without affecting desktop behavior.
  • Chores

    • Bumped version to 4.1.15.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 11, 2025

Walkthrough

Bumped libs/windy-sounding package version to 4.1.15 and added a mobile-specific CSS rule enabling pointer events for the plugin content in styles.less.

Changes

Cohort / File(s) Summary
Version bump
libs/windy-sounding/package.json
Update version from 4.1.14 to 4.1.15.
Mobile CSS tweak
libs/windy-sounding/src/styles.less
Add mobile rule to set pointer-events: initial for plugin content.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title directly reflects the main change in the PR—the stylesheet modification that re-enables pointer events for the Windy plugin on mobile—and is concise and specific enough for a reviewer to understand the primary intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I thump my paw, a tiny cheer,
A version hop—now crystal clear.
On phones, a tap can dance and play,
The winds respond without delay.
I nibble code like garden greens—
Small tweaks, swift breezes in our scenes. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vicb/windy-pointers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Sep 11, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
libs/windy-sounding/package.json (1)

8-12: Repository directory likely incorrect.

This package lives under libs/windy-sounding but repository.directory points to libs/windy-plugin. Recommend correcting to avoid tooling confusion on GitHub/npm metadata.

Apply:

   "repository": {
     "type": "git",
     "url": "https://github.com/vicb/flyxc.git",
-    "directory": "libs/windy-plugin"
+    "directory": "libs/windy-sounding"
   },
libs/windy-sounding/src/styles.less (2)

8-10: Prefer pointer-events: auto (and consider specificity).

initial resolves to auto here; using auto is clearer. If Windy sets pointer-events: none with higher specificity/inline, you may need !important.

  • Manually verify on a real device that interactions inside the plugin work and that map pan/zoom outside the plugin remain unaffected.
-#device-mobile #plugin-windy-plugin-fxc-soundings .plugin__content {
-  pointer-events: initial;
-}
+#device-mobile #plugin-windy-plugin-fxc-soundings .plugin__content {
+  pointer-events: auto;
+  /* Use !important only if upstream rules still block events */
+  /* pointer-events: auto !important; */
+}

8-10: Add a short rationale comment.

Future maintainers will benefit from knowing this is a mobile fix for Windy’s event handling.

 #device-mobile #plugin-windy-plugin-fxc-soundings .plugin__content {
-  pointer-events: initial;
+  /* Enable hit-testing on mobile; Windy may disable it by default */
+  pointer-events: auto;
 }
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95c2d32 and 57bded7.

⛔ Files ignored due to path filters (1)
  • libs/windy-sounding/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • libs/windy-sounding/package.json (1 hunks)
  • libs/windy-sounding/src/styles.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Sourcery review
  • GitHub Check: build (20.x)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
libs/windy-sounding/package.json (1)

3-3: Patch bump looks good.

Version increment to 4.1.15 is appropriate for a CSS-only tweak.

Please ensure the lockfile is updated and CI publishes/consumes this version as expected.

@vicb vicb merged commit 1369287 into master Sep 11, 2025
7 checks passed
@vicb vicb deleted the vicb/windy-pointers branch September 11, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant