Add Ghostty extension by domainus · Pull Request #283 · vicinaehq/extensions

domainus · 2026-05-31T02:19:57Z

Adds a Linux Ghostty extension for Vicinae.

Features:

New Ghostty window
New Ghostty tab via KDE/KWin focus + ydotool shortcut
Focus Ghostty window via wmctrl
Run YAML launch configurations
Open paths in Ghostty
Manage and validate Ghostty config

Verification:

npm test
npx vici lint
npm run build -- --out /tmp/ghostty-store-build

aurelleb · 2026-08-02T05:32:15Z

@clankus-aurelius review

clankus-aurelius · 2026-08-02T05:32:18Z

Thanks for contributing an extension to Vicinae! 👋

Before publication, this pull request receives two reviews:

An automated review for extension guidelines, safety, error handling, and likely correctness issues.
A final review from a Vicinae maintainer.

🔴 Contributor changes requested. Address the blocking inline findings and push a new commit; the bot will review it automatically.

1 blocking finding must be addressed.

The automated reviewer examines only the current commit. New commits invalidate its previous decision and start another review.

clankus-aurelius

The new-tab command has a blocking silent-failure path. Five additional correctness and error-reporting problems affect window targeting, launch configurations, path handling, and fallback launching.

Automated review found 1 publication-blocking issue.

clankus-aurelius · 2026-08-02T05:35:06Z

+  try {
+    focusGhosttyWithKWin();
+    Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 250);
+    sendNewTabShortcut();


🔴 Blocking — Missing ydotool socket is treated as success

Rule: CORRECTNESS-001

sendNewTabShortcut returns false when the socket is absent, but the result is ignored. The command then exits without creating a tab, opening Ghostty, or showing feedback.

Suggested resolution: Treat a false result as a failure so the existing fallback runs.

Suggested change

sendNewTabShortcut();

if (!sendNewTabShortcut()) throw new Error("ydotool socket not found");

clankus-aurelius · 2026-08-02T05:35:06Z

+  const cap = String(w.caption || '').toLowerCase();
+  if (klass.includes('ghostty') || cap.includes('ghostty')) {


🟠 Warning — Window caption can select an unrelated application

Rule: CORRECTNESS-001

The KWin script accepts any window whose caption contains “ghostty”. A browser or editor displaying Ghostty-related content can therefore receive Ctrl+Shift+T instead of Ghostty.

Suggested resolution: Identify Ghostty only from its application/resource class, not its caption.

Suggested change

const cap = String(w.caption || '').toLowerCase();

if (klass.includes('ghostty') || cap.includes('ghostty')) {

if (klass.includes('ghostty')) {

clankus-aurelius · 2026-08-02T05:35:06Z

+export function focusWindow(id: string): void { execFileSync("wmctrl", ["-ia", id], { timeout: 3000 }); }
+export function listGhosttyWindows(): { id: string; title: string }[] {
+  const out = execFileSync("wmctrl", ["-lx"], { encoding: "utf8", timeout: 3000 });
+  return out.split(/\n/).filter(l => /ghostty/i.test(l)).map(l => { const parts = l.trim().split(/\s+/); return { id: parts[0], title: parts.slice(4).join(" ") || "Ghostty" }; });


🟠 Warning — Window search matches titles instead of application class

Rule: CORRECTNESS-001

The filter tests the entire wmctrl line, including the window title, so unrelated windows with “Ghostty” in their title appear in the results and can be focused.

Suggested resolution: Parse the wmctrl application-class field and filter that field for Ghostty before constructing list items.

clankus-aurelius · 2026-08-02T05:35:06Z

+  const out = execFileSync("wmctrl", ["-lx"], { encoding: "utf8", timeout: 3000 });
+  return out.split(/\n/).filter(l => /ghostty/i.test(l)).map(l => { const parts = l.trim().split(/\s+/); return { id: parts[0], title: parts.slice(4).join(" ") || "Ghostty" }; });
+}
+export function resolveOpenPath(input?: string): string { const p = expandHome((input || "").trim() || homedir()); try { const st = lstatSync(p); return st.isDirectory() ? resolve(p) : dirname(resolve(p)); } catch { return homedir(); } }


🟠 Warning — Invalid paths silently open the home directory

Rule: CORRECTNESS-001

Any nonexistent or inaccessible supplied path is converted to the home directory, so a typo causes “Open with Ghostty” to open the wrong location without feedback.

Suggested resolution: Let path lookup failures propagate to the command’s existing failure toast instead of substituting the home directory.

Suggested change

export function resolveOpenPath(input?: string): string { const p = expandHome((input || "").trim() || homedir()); try { const st = lstatSync(p); return st.isDirectory() ? resolve(p) : dirname(resolve(p)); } catch { return homedir(); } }

export function resolveOpenPath(input?: string): string {

const p = expandHome((input || "").trim() || homedir());

const st = lstatSync(p);

return st.isDirectory() ? resolve(p) : dirname(resolve(p));

}

clankus-aurelius · 2026-08-02T05:35:06Z

+  const safe = name.toLowerCase().replace(/[^a-z0-9._-]+/g, "-").replace(/^-|-$/g, "") || "launch-config";
+  const path = join(launchConfigDir, `${safe}.yaml`);
+  const parsed = YAML.parse(yaml);
+  if (!parsed || !Array.isArray(parsed.windows)) throw new Error("Launch config must include a windows list");


🟠 Warning — Launch configuration validation accepts malformed command fields

Rule: CORRECTNESS-001

Validation checks only that windows is an array. For example, a scalar commands value is saved successfully, then collectCommands spreads it into individual characters and executes the wrong command sequence.

Suggested resolution: Validate the nested windows, tabs, layouts, panes, cwd, and commands types when loading and saving configurations; require commands to be arrays of strings.

clankus-aurelius · 2026-08-02T05:35:06Z

+      const child = spawn(bin, [], { detached: true, stdio: "ignore", cwd: process.env.HOME || undefined });
+      child.unref();
+      await showToast({ style: Toast.Style.Failure, title: "Could not send new-tab shortcut", message: "Opened Ghostty instead. Check qdbus, KWin scripting, and ydotool." });


🟠 Warning — Fallback reports Ghostty opened before spawn succeeds

Rule: UX-001

spawn reports a missing or non-executable binary asynchronously, so this try/catch can still show “Opened Ghostty instead” and leave the process error unhandled when no window was opened.

Suggested resolution: Use the existing checked Ghostty spawning helper or await the child spawn/error event before reporting the fallback outcome.

aurelleb · 2026-08-02T05:43:09Z

For the window focus code, did you think about using the Window Management API?

Dom added 2 commits May 30, 2026 19:19

Add Ghostty extension

e331ec9

Fix package-lock metadata

e1aee43

clankus-aurelius added the ai-reviewing Automated extension review is running label Aug 2, 2026

clankus-aurelius requested changes Aug 2, 2026

View reviewed changes

clankus-aurelius added ai-changes-requested Automated review found blocking issues and removed ai-reviewing Automated extension review is running labels Aug 2, 2026

Navigation Menu

Uh oh!

Add Ghostty extension - #283

Add Ghostty extension#283
domainus wants to merge 2 commits into
vicinaehq:mainfrom
domainus:add-ghostty-extension

domainus commented May 31, 2026 •

edited

Loading

Uh oh!

aurelleb commented Aug 2, 2026

Uh oh!

clankus-aurelius commented Aug 2, 2026 •

edited

Loading

Uh oh!

clankus-aurelius left a comment

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

clankus-aurelius Aug 2, 2026

Uh oh!

aurelleb commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	sendNewTabShortcut();
	if (!sendNewTabShortcut()) throw new Error("ydotool socket not found");

		const cap = String(w.caption \|\| '').toLowerCase();
		if (klass.includes('ghostty') \|\| cap.includes('ghostty')) {

	const cap = String(w.caption \|\| '').toLowerCase();
	if (klass.includes('ghostty') \|\| cap.includes('ghostty')) {
	if (klass.includes('ghostty')) {

Uh oh!

Conversation

domainus commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aurelleb commented Aug 2, 2026

Uh oh!

clankus-aurelius commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clankus-aurelius left a comment

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

clankus-aurelius Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

aurelleb commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

domainus commented May 31, 2026 •

edited

Loading

clankus-aurelius commented Aug 2, 2026 •

edited

Loading