build(linux): allow skipping file installation - #1607
Open
embik wants to merge 1 commit into
Open
Conversation
Signed-off-by: Marvin Beckers <mail@embik.me>
|
For linux build changes, a quick note on required environment variables in manifest generation would help review and troubleshooting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm one of the Gentoo chads called out here:
vicinae/CMakeLists.txt
Line 26 in 9878d64
I am admittedly new to writing ebuilds (the packaging instructions for Gentoo), but noticed that the unconditional attempt to install files into
CMAKE_INSTALL_PREFIX(/usrin practice, I suppose) was violating the build sandbox for my ebuild.Instead of letting cmake install those files (themes,
.desktopfiles, icons, systemd unit), I would like the package manager to do it fromextra/directly.This adds
INSTALL_SHARED_FILES,ONby default (so my little snowflake distribution doesn't break everyone else's build/install process), which can be toggledOFFto delegate installation of files to an external process. Hope this is useful, if not please feel free to close.