Skip to content

fix(build): resolve AppImage version from manifest - #1630

Open
albertonoys wants to merge 1 commit into
vicinaehq:mainfrom
albertonoys:fix/appimage-version-labeling
Open

fix(build): resolve AppImage version from manifest#1630
albertonoys wants to merge 1 commit into
vicinaehq:mainfrom
albertonoys:fix/appimage-version-labeling

Conversation

@albertonoys

Copy link
Copy Markdown

Read version and commit directly from manifest.yaml for AppImage targets in Makefile and CI workflows. This prevents builds from defaulting to 'v0.0.0 (commit unknown)' when git commands fail or lack a git tree.

Fixes #1596

@arturict

Copy link
Copy Markdown

For AppImage manifest resolution, include reproduction for stale cache behavior when version changes.

@albertonoys

Copy link
Copy Markdown
Author
  1. When build-appimage.yaml is triggered, the job runs inside an AppImage build container with a shallow checkout
  2. Before this fix, the Configure CMake step did not pass -DVICINAE_GIT_TAG or -DVICINAE_GIT_COMMIT_HASH
  3. CMake fell back to git describe --tags inside the container, which failed, setting v0.0.0 unknown
    (The same happened locally with make appimage from a source tree without tags)
  4. vicinae versionin the resulting AppImage reports v0.0.0 (commit unknown) regardless of the actual release version, and the update (install) script always sees a newer version

With this change, the Makefile and CI workflows read TAG and COMMIT from manifest.yaml (kept up to date by scripts/bump_version.sh) and forward them to cmake explicitly, bypassing the git fallback.

Reads version and commit directly from manifest.yaml for AppImage
targets in Makefile and CI workflows. This prevents builds from
defaulting to 'v0.0.0 (commit unknown)' when git commands fail or lack a
git tree.

Fixes vicinaehq#1596
@albertonoys
albertonoys force-pushed the fix/appimage-version-labeling branch from 318d903 to 9f254b8 Compare July 13, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vicinae version says wrong version

2 participants