Security - handle /debug/Battery* in a safe way and protect battery #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/Debug/BatteryOperationalLimits/SolarVoltageOffset /Debug/BatteryOperationalLimits/VebusVoltageOffset /Debug/BatteryOperationalLimits/CurrentOffset were not handled correctly and as a writable paths allowed to enter any value. These values are used in _adjust_battery_operational_limits and _update_solarchargers_and_vecan Setting a large positive voltage offset could cause overcharging of batteries, potentially leading to thermal runaway, fire, or explosion in lithium battery systems. Setting a large negative current offset could prevent charging entirely. These debug paths override BMS safety limits which exist specifically to prevent dangerous conditions. Implemented sort of a limit, applied to all three values and based on tests I found. Unfortunately there's no deployment code to exclude these paths from production releases.
tmeinlschmidt
force-pushed
the
fixes/dvcc_security
branch
from
b4b81bf to
a568793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a dangeerous situation when paths
were not handled correctly and as a writable paths allowed to enter any value.
These values are used in _adjust_battery_operational_limits and _update_solarchargers_and_vecan
Setting a large positive voltage offset could cause overcharging of batteries, potentially leading to thermal runaway, fire, or explosion in lithium battery systems. Setting a large negative current offset could prevent charging entirely. These debug paths override BMS safety limits which exist specifically to prevent dangerous conditions.
Implemented sort of a limit, applied to all three values and based on tests I found.
Unfortunately there's no deployment code to exclude these paths from production releases.