Fix #1589: Prevent crash when fetching registers beyond map end#55
Open
drurew wants to merge 3 commits intovictronenergy:masterfrom
Open
Fix #1589: Prevent crash when fetching registers beyond map end#55drurew wants to merge 3 commits intovictronenergy:masterfrom
drurew wants to merge 3 commits intovictronenergy:masterfrom
Conversation
…89). Correctly handle lowerBound() returning end() when address is inside the last register block.
…int16_ul type (#1580)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash in where was accessed safely immediately after verifying that was not in a combined boolean/logical check, but in some edge cases or compiler behaviors could still be problematic. This change explicitly handles the check first and returns.