Mock: use correct phase counts when changing page configurations #2669
+52
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing Brief/Overview mock configurations, clear the power/current values for phases that are unused; also, update SystemAcImpl.qml to avoid adding data from phases beyond the desired phase count for a service. Otherwise, the power/current values for unused phases will be picked up by SystemAcImpl, and it will continue to use the old phase count for calculating /Ac/Consumption, /Ac/ConsumptionOnOutput and /Ac/ConsumptionOnInput. This was causing the AC Loads widget to show the wrong number of phases when moving from a 3-phase to 1-phase configuration, and also causing the Grid widget to include state power/current data in its total when moving from a 3-phase to 1-phase configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing Brief/Overview mock configurations, clear the power/current values for phases that are unused; also, update SystemAcImpl.qml to avoid adding data from phases beyond the desired phase count for a service. Otherwise, the power/current values for unused phases will be picked up by SystemAcImpl, and it will continue to use the old phase count for calculating /Ac/Consumption, /Ac/ConsumptionOnOutput and /Ac/ConsumptionOnInput.
This was causing the AC Loads widget to show the wrong number of phases when moving from a 3-phase to 1-phase configuration, and also causing the Grid widget to include state power/current data in its total when moving from a 3-phase to 1-phase configuration.