VE.Bus: mention system redetect option if mode/limit control is disabled #2674
Conversation
components/CommonWords.qml
Outdated
| : "" | ||
| } | ||
|
|
||
| function noAdjustableByBms(serviceType, deviceName) { |
There was a problem hiding this comment.
"DueTo" rather than "By"?
components/CommonWords.qml
Outdated
| //% "This setting is disabled when a VE.Bus BMS is connected." | ||
| const s = qsTrId("common_words_setting_disabled_when_bms_connected") | ||
| return serviceType === "vebus" | ||
| ? s + " " + go_to_redetect_system.arg(deviceName) |
There was a problem hiding this comment.
I don't think we can do it with concatenation, as different languages will have different grammar / ordering.
I'd expect it to be something like:
//: The first argument is the translated string describing that the setting is disabled due to a BMS being connected, the second argument is the translated string telling the user to visit the Redetect System page
//% "%1 %2"
qsTrId("common_words_setting_disabled_go_to_redetect").arg(s, go_to_redetect_system.arg(deviceName))
There was a problem hiding this comment.
Yeah that's a good point - I'm not sure how to do both cases (with and without the second string) without duplicating the translations?
There was a problem hiding this comment.
Oh I see, you mean we could add a translation id just to do the concatenation. Should we refer to to the translation ids in that case, so translators can see the exact text that is being joined?
There was a problem hiding this comment.
Updated to refer to the translation ids.
Also, since the full text can be quite long, I've removed the notification timeout so that the user has to dismiss it explicitly.
If the user attempts to change the VE.Bus current limit or mode, and this action is disabled because a BMS or DMC is connected, provide information about the "Redetect VE.Bus system" option in the error notification text. This aligns with the behaviour in gui-v1. Fixes #2673
blammit
force-pushed
the
blam/vebus-dmc-error-text
branch
from
1e6a66b to
8669e8d
Compare
If the user attempts to change the VE.Bus current limit or mode, and this action is disabled because a BMS or DMC is connected, provide information about the "Redetect VE.Bus system" option in the error notification text.
This aligns with the behaviour in gui-v1.
Fixes #2673
Testing in mock mode:
In data/mock/conf/services/quattro-3phase-grid-genset.json, set "/Devices/Dmc/Version" or "/Devices/Bms/Version" to 1, and then try to set the current limit in the control cards.