Settings: add "mixed" option for current/watts preference #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a custom implementation for showing Amps vs Watts, as ElectricalQuantityLabel automatically shows the quantity in Amps/Watts depending on the user preferences. Contributes to #2200
This avoids a custom implementation for showing Amps vs Watts, as ElectricalQuantityLabel automatically shows the quantity in Amps/Watts depending on the user preferences. Also remove unused preferredUnit/Quantity from System.qml. Contributes to #2200
Add a "Mixed" Electrical Power Display option, below "Power (Watts)" and "Current (Amps)". Instead of preferring solely Watts or Amps, this option will show the AC-side in Power and the DC-side in Current. Note this only affects Watts/Amps displays in the Boat, Brief and Overview pages. Replace Global.systemSettings.electricalQuantity with Global.systemSettings.electricalPowerDisplay, which indicates the user- selected mode. ElectricalQuantityLabel now has a 'sourceType' property, which should be set ElectricalQuantity_Source_<Ac|Dc> depending on the data source. It can also be ElectricalQuantity_Source_Any (the default), which is useful for cases like the SolarWidget, which may show combined AC/DC sources. Contributes to #2200
Clean up the ElectricalQuantityLabel API by replacing the acInputMode property with a sourceType of ElectricalQuantity_Source_AcInputOnly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.