feat: split the _close method from mediaDetach #6966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
approved these changes
Jan 31, 2025
robwalch
reviewed
Jan 31, 2025
Comment on lines
1284
to
+1286
| private onMediaDetached() { | ||
| const media = this.media; | ||
| const mediaKeysList = this.mediaKeySessions; | ||
|
|
There was a problem hiding this comment.
onMediaDetached has an event object of type MediaDetachedData that has an optional transferMedia property. This is used in Interstitials or custom applications performing gapless playback by transferring the MediaSource and its SourceBuffers to another player instance. In those cases would this change work just as well?
There was a problem hiding this comment.
If an issue comes up we can follow up with additional changes. Merging for v1.6.0-beta.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This PR aims to provide a
_closemethod in theEME-Controllerto prevent the clearing of the key session and reset data after detached media.It will work for some FAST(free ad-supported streaming television) with one video element. Here is what we expected:
Here is a demo video:
1.22.mp4
CodePen Demo: https://codepen.io/Jack_Pu/pen/dPbgGGL
Why is this Pull Request needed?
We don't want to clear the key session and relate media keys. We can keep it until we force to destory it.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist