Conversation
|
Note Urls will be available only after netlify deploy. PreviewApi Reference
Demo |
✅ Deploy Preview for videojsdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 63.95% 65.87% +1.92%
==========================================
Files 114 117 +3
Lines 4830 4906 +76
Branches 633 684 +51
==========================================
+ Hits 3089 3232 +143
+ Misses 1733 1666 -67
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| Disabled = 'disabled', | ||
| Hidden = 'hidden', | ||
| Showing = 'showing', | ||
| } |
There was a problem hiding this comment.
these 2 seem to match default text track interfaces, so you can simply use interfaces globally available in typescript via dom
| } as TextTrack; | ||
| videoElement.textTracks[videoElement.textTracks.length] = textTrack; | ||
| return textTrack; | ||
| }; |
There was a problem hiding this comment.
you can use mockito, or simply videoElement = { addTextTrack: vi.fn() } in beforeEach
There was a problem hiding this comment.
The only issue I have with mocking this with an empty vi.fn is that it doubles as a test utility. If this is mocked with vi, the text track would need to be added manually in each test.
There was a problem hiding this comment.
I think this is fine
There was a problem hiding this comment.
Cool, fixing the size limits and this should be good to go.
| } | ||
| } | ||
| return null; | ||
| }; |
|
I see this PR is mostly about text tracks, could we please verify that load flow works as expected and native playback works fine, eg: some basic mp4 file in chrome/firefox/safari and hls in safari? |
3 participants
Description
Add native-pipeline and associated tests.
Specific Changes proposed
Implement a basic native pipeline.
Requirements Checklist