fix: translation matrix now correct reported as Int32Array[9]#411
Open
kentuckyfriedtakahe wants to merge 2 commits intovideojs:mainfrom
Open
fix: translation matrix now correct reported as Int32Array[9]#411kentuckyfriedtakahe wants to merge 2 commits intovideojs:mainfrom
kentuckyfriedtakahe wants to merge 2 commits intovideojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently returning the 36 byte matrix inside
mvhdandtkhdas a Int32Array[36] where the top 24 bits are always zero. This appears to be in error and it would make more sense to return these 36 octets a Int32Array[9] to properly represent a 3x3 affine transform.