chore(root): migrate typecheck to @typescript/native-preview (tsgo)#1400
Merged
chore(root): migrate typecheck to @typescript/native-preview (tsgo)#1400
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (3)
Skins (29)
UI Components (25)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (26)
UI Components (20)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
sampotts
previously approved these changes
Apr 22, 2026
mihar-22
force-pushed
the
t3code/e58fa31b
branch
from
8e1f517 to
6a84438
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Upgrades tsdown across all packages to 0.21.9, removes redundant per-package typescript devDependencies (now resolved via root), and migrates dts generation to use tsgo with dedicated per-package tsconfig.dts.json files.
…ipts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prepares for TypeScript 7.0 landing under the `typescript` package. The compiler API needed by build scripts is pinned to 6.x via the official compatibility alias. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Not needed with tsgo — it actually slows typecheck down (~1.3s vs ~0.8s). The flag was a tsc-specific optimization for reading .d.ts over source. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lotted src/types was deleted in #282 but tsdown.config.ts still listed it as an entry point, and slotted.ts still imported Falsy from it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ort in slotted" This reverts commit 0b6d00c.
mihar-22
force-pushed
the
t3code/e58fa31b
branch
from
cea3545 to
7d3b24d
Compare
cjpillsbury
added a commit
that referenced
this pull request
Apr 23, 2026
PR #1400 dropped typescript from every package in favor of @typescript/native-preview (tsgo) at the workspace root. vitest's typecheck project still defaulted to the tsc binary, which is no longer installed, so `pnpm -F @videojs/spf test` fails with `Error: spawn tsc ENOENT`. This is the only failing job in CI on this branch and is unrelated to the docs work. vitest's typecheck.checker accepts any binary that understands --noEmit --pretty false --incremental --tsBuildInfoFile; tsgo does, and pnpm puts node_modules/.bin/tsgo on PATH for lifecycle scripts, so 'tsgo' resolves without any new devDependency. Verified against the existing create-composition-types.test-d.ts: clean runs report "Type Errors: no errors" and exit 0, and intentionally broken type tests surface as TypeCheckError with file/line/column parsed from tsgo's tsc-compatible diagnostic output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the entire monorepo from
typescript/tscto@typescript/native-preview(tsgo) — the new native Go-based TypeScript compiler.Changes
typecheckscript: replacedtsc --buildwithtsgo --buildtypescript: ^6.0.2→@typescript/native-preview: betadisableSourceOfProjectReferenceRedirectremoved fromtsconfig.base.json— this was atsc-specific optimization; it actually makestsgoslowerallowSyntheticDefaultImports/esModuleInteropremoved — redundant withverbatimModuleSyntax^0.21.9across all packages (adds tsgo support inrolldown-plugin-dts)typescriptdevDep removed —@typescript/native-previewis hoisted from rootdts: { tsgo: true }enabled in all packagetsdown.config.tsfiles — declaration files now generated by tsgotsconfig.dts.jsonadded to packages that needed one (utils,store,element,spf,html,react,skins,core) — tsgo requires a tsconfig withoutcomposite: trueordeclarationDirso--outDiris respectedsite/keepstypescriptvia aliasnpm:@typescript/typescript6@^6.0.0— build scripts use the TS compiler API which isn't available in@typescript/native-previewBenchmark (cold, no tsbuildinfo)
pnpm typecheck(cold)pnpm typecheck(warm)build:packages(8 pkgs, seq.)Test plan
pnpm build)pnpm typecheck)🤖 Generated with Claude Code
Note
Medium Risk
Medium risk because it swaps the monorepo typechecking and
.d.tsgeneration pipeline fromtsctotsgo, which can change diagnostics/output and affect build tooling across all packages.Overview
Switches the root
typecheckscript fromtsc --buildtotsgo --buildand replaces the workspacetypescriptdevDependency with@typescript/native-preview.Updates package build tooling to generate declarations via
tsgoby bumpingtsdownand changing each package’stsdown.config.tsdtssettings, adding new per-packagetsconfig.dts.jsonfiles where needed.Cleans up TypeScript config/deps (removes per-package
typescriptdevDeps and dropsesModuleInterop/allowSyntheticDefaultImportsfromtsconfig.base.json), while keepingsiteontypescriptvia an npm alias for TS compiler API usage.Reviewed by Cursor Bugbot for commit 7d3b24d. Bugbot is set up for automated code reviews on this repo. Configure here.