You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Updates spinner rendering and animation control in SVG/CSS; risk is mainly UI/UX regressions and potential browser-compat issues around :has()/custom-property-driven animations.
Overview
Replaces the spinner icons’ SMIL <animate> blocks with an inline CSS keyframe animation applied to stroked <line> segments (sharper diagonals) that animates by default via --media-spinner-animation.
Updates default/minimal buffering and preview styles (CSS and Tailwind) to set --media-spinner-animation:none whenever the spinner is hidden, preventing offscreen/hidden spinners from keeping animation ticks alive.
Also adds .pnpm-store/ to .gitignore.
Reviewed by Cursor Bugbot for commit 0f54ae9. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Hidden spinner SVGs no longer keep browser frame/update ticks alive, while standalone spinner SVGs still animate by default.
Closes #1325
Checks
Note
Medium Risk
Updates spinner rendering and animation control in SVG/CSS; risk is mainly UI/UX regressions and potential browser-compat issues around
:has()/custom-property-driven animations.Overview
Replaces the spinner icons’ SMIL
<animate>blocks with an inline CSS keyframe animation applied to stroked<line>segments (sharper diagonals) that animates by default via--media-spinner-animation.Updates default/minimal buffering and preview styles (CSS and Tailwind) to set
--media-spinner-animation:nonewhenever the spinner is hidden, preventing offscreen/hidden spinners from keeping animation ticks alive.Also adds
.pnpm-store/to.gitignore.Reviewed by Cursor Bugbot for commit 0f54ae9. Bugbot is set up for automated code reviews on this repo. Configure here.