fix(site): add 'use client' to ejected skin Next.js output#1488
Merged
fix(site): add 'use client' to ejected skin Next.js output#1488
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (3)
Skins (29)
UI Components (25)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (26)
UI Components (20)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
sampotts
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-ejected-skins script was missing the
'use client'directivein the React output, causing hydration errors when developers copy the
ejected skin example from the Next.js tab on the skins docs page.
Prepends
'use client';to the reorganized React output so it matchesthe packaged skin sample.
Closes 1486
Note
Low Risk
Low risk: a small string prefix change in the site build script that only affects generated ejected-skin snippets, with no runtime logic changes beyond Next.js hydration behavior for copied examples.
Overview
Fixes the React ejected-skin snippet generation for Next.js by prepending the
'use client';directive to the output ofreorganizeReactOutputinbuild-ejected-skins.ts.This ensures the copy-paste React skin examples are treated as client components and avoids hydration issues when used in Next.js apps.
Reviewed by Cursor Bugbot for commit f4c2fa4. Bugbot is set up for automated code reviews on this repo. Configure here.