docs(site): fix feature export names in features and presets guides#1513
Open
ronald-urbina wants to merge 1 commit intomainfrom
Open
docs(site): fix feature export names in features and presets guides#1513ronald-urbina wants to merge 1 commit intomainfrom
ronald-urbina wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (5)
Skins (30)
UI Components (33)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (27)
UI Components (26)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 1481
Correct bare feature names in the features and presets concept guides to use
the proper
*Feature-suffixed exports (playbackFeature,volumeFeature,timeFeature,controlsFeature) that are actually exported from the package.Also adds
controlsFeatureto the individual features examples since without it,the controls root and controls components won't render in custom-feature players
Note
Low Risk
Low risk documentation-only change that updates sample imports/usages; no runtime code paths are modified.
Overview
Updates the
FeaturesandPresetsconcept guides to use the correct*Feature-suffixed exports (e.g.playbackFeature,volumeFeature,timeFeature) instead of the previously documented bare names.Also amends the “individual features” examples to include
controlsFeatureso controls render when constructing a player from a custom feature list.Reviewed by Cursor Bugbot for commit 33c21d2. Bugbot is set up for automated code reviews on this repo. Configure here.