docs(site): add ejected skin section to installation guide#1524
Open
ronald-urbina wants to merge 1 commit intomainfrom
Open
docs(site): add ejected skin section to installation guide#1524ronald-urbina wants to merge 1 commit intomainfrom
ronald-urbina wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (5)
Skins (30)
UI Components (34)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (27)
UI Components (27)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74cceee. Configure here.
| import HumanCase from '@/components/docs/HumanCase.astro'; | ||
| import LLMCase from '@/components/docs/LLMCase.astro'; | ||
| import { TabsRoot, TabsList, TabsPanel, Tab } from '@/components/Tabs.tsx'; | ||
| import EjectedSkin from '@/components/docs/EjectedSkin.astro'; |
There was a problem hiding this comment.
Unused EjectedSkin import in installation MDX
Low Severity
EjectedSkin is imported in installation.mdx but never referenced as a component anywhere in the file. Only EjectedSkinToggle is used (line 158), and that component already imports EjectedSkin internally in EjectedSkinToggle.astro. This import is dead code.
Reviewed by Cursor Bugbot for commit 74cceee. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 1385
Adds a new "Ejecting a skin" section to the installation guide so users
can access the ejected skin workflow without going back to the homepage.
Changes
EjectedSkinTogglecomponent with a default/minimal radio switcherthat shows the correct ejected-skin install steps per variant
installation.mdxwired up with the toggle and a teaser link near theskin picker section
Note
Low Risk
Low risk documentation/UI addition; changes are limited to new site components and MDX content with no impact on player/runtime logic.
Overview
Adds an “Ejecting a skin” section to the installation guide, including a teaser link near the skin picker to drive users to the new workflow.
Introduces
EjectedSkinToggle(.astro+ client TSX) that lets readers switch between Default and Minimal variants via anImageRadioGroup, showing the correspondingEjectedSkincode snippets for the current framework (HTML vs React).Reviewed by Cursor Bugbot for commit 74cceee. Bugbot is set up for automated code reviews on this repo. Configure here.