docs(site): add "No Skin" option to installation skin picker#1525
Open
ronald-urbina wants to merge 1 commit intomainfrom
Open
docs(site): add "No Skin" option to installation skin picker#1525ronald-urbina wants to merge 1 commit intomainfrom
ronald-urbina wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (8)
Players (5)
Skins (30)
UI Components (34)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (7)
Skins (27)
UI Components (27)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c2353a. Configure here.
| ${mediaComment} | ||
| <${tag} src="${src}"${playsInline}></${tag}> | ||
| </${providerTag}>`; | ||
| } |
There was a problem hiding this comment.
HTML markup drops skin for background-video when skin is "none"
Medium Severity
In generateHTMLMarkup, the skin === 'none' check on line 140 fires before any background-video handling, producing a bare <background-video-player> without a skin wrapper. Every other codegen function (getCdnFileName, generateHTMLJSImports, generateReactCreateCode) checks for background-video first and always includes the background-video skin. Since the skin store isn't reset when switching use cases and the SkinPicker unmounts for background-video, a user who selects "No Skin" then switches to "Background Video" will see inconsistent generated code — HTML markup without a skin, but JS imports and React output that include the skin.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7c2353a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 929
Adds a "No Skin" option to the skin picker on the installation page,
letting users see what a bare player setup looks like without any
pre-built skin.
Changes
Skintype extended with'none'SkinPickershows a third "No Skin" tile (Code2 icon) for bothvideo and audio use cases
registers the player
wrapper in the JSX output
video-player.js/audio-player.jsNote
Medium Risk
Medium risk because it extends the
Skinunion and changes HTML/React/CDN snippet generation paths, which could impact the correctness of installation code shown for multiple use cases if edge cases are missed.Overview
Adds a new
Skinoption ('none') so the installation page can generate examples of a bare player without a pre-built UI skin.Updates the skin picker UI to include a No Skin tile for both audio and video. Adjusts HTML, React, and CDN code generation to skip skin wrapper tags/components and skin CSS/imports when
skin === 'none', while still importing/registering the appropriate player (and renderer/media modules as needed).Reviewed by Cursor Bugbot for commit 7c2353a. Bugbot is set up for automated code reviews on this repo. Configure here.