Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sampotts
changed the title
Contributor
📦 Bundle Size Report🎨 @videojs/html
Presets (7)
Media (8)
Players (5)
Skins (30)
UI Components (35)
Sizes are marginal over the root entry point. ⚛️ @videojs/react
Presets (7)
Media (7)
Skins (27)
UI Components (29)
Sizes are marginal over the root entry point. 🧩 @videojs/core
Entries (9)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e726e5b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm typecheckpnpm -F @videojs/core test src/core/ui/playback-rate-menu/tests/playback-rate-menu-core.test.ts src/dom/ui/menu/tests/create-menu.test.ts src/dom/ui/popover/tests/popover.test.tspnpm -F @videojs/html test src/ui/playback-rate-menu/tests/playback-rate-menu-element.test.ts src/ui/menu/tests/menu-element.test.tspnpm -F @videojs/react test src/ui/playback-rate-menu/tests/playback-rate-menu.test.tsx src/ui/menu/tests/menu.test.tsx src/player/tests/context.test.tsxCloses #623.
Note
Medium Risk
Medium risk because it changes core
Popover/Menuinteraction semantics (grouped auto-close, focus restoration, keyboard handling) and introduces new positioning boundary logic that could affect all popups.Overview
Adds a new playback-rate menu primitive (
PlaybackRateMenuCore+ data attrs) and wires it into new HTML custom elements (media-playback-rate-menu*) and React exports/hooks, including dynamic option rendering and selection.Updates shipped skins to replace the playback-rate button+tooltip with the new menu (radio options) and sets popup/tooltip
boundary="viewport"in several presets.Improves shared popup infrastructure: introduces
PopupGroupto ensure only one top-level popup is open at a time, addscontrols-hiddenclose handling, refines menu highlighting (prefer checked/selected item; allow highlight without focusing on pointer hover), swallows trigger navigation keys while open, and enhances positioning with configurableboundary+boundaryOffsetCSS vars and shared DOMRect/boundary utilities.Reviewed by Cursor Bugbot for commit 2339556. Bugbot is set up for automated code reviews on this repo. Configure here.