feat(skin): add title display to minimal skin#1604
Draft
Jerricho93 wants to merge 3 commits into
Draft
Conversation
Introduces MetadataFeature with title state, TitleCore/TitleElement (HTML), Title.Value (React), and default skin styling. Includes: - metadataFeature with setTitle and MediaSession sync - <media-title> / Title.Value components reading from store - Play button aria-label enriched with title when set - Default skin overlay/title CSS and Tailwind variants - Sandbox sources wired with title; site API reference page Closes videojs#1123 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds media-title to minimal skin templates (HTML and React) and creates the corresponding CSS/Tailwind styling. Adjusts the overlay gradient to match the default skin (softer dual-direction scrim, no fixed pixel stops). Depends on: pr/title-core-default Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Jerricho93 is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for vjs10-site pending review.Visit the deploys page to approve it
|
Bottom gradient always visible; top gradient activates only when a title is present via :has([data-has-title]). CSS and Tailwind implementations aligned to match the default skin pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Blocked by #1603 — do not review or merge until
feat: add title display and media metadata state(#1603) is merged first. The diff here includes all of PR #1603's changes; once that lands, this PR's diff will shrink to only the minimal skin files.Summary
<media-title>/Title.Valueto minimal skin templates (HTML and React, CSS and Tailwind variants)minimal/css/components/title.cssandminimal/tailwind/components/title.tswith the same fade-in behavior as the default skin0.3/0.15top,0.5/0.3bottom) replacing the original single-direction dark gradientTest plan
pnpm typecheckpnpm lintpnpm check:workspace