feat(core): add status announcer state updates#1659
Open
sampotts wants to merge 11 commits into
Open
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
📦 Bundle Size Report🎨 @videojs/html
Presets (7)
Media (9)
Players (5)
Skins (30)
UI Components (36)
Sizes are marginal over the root entry point. ⚛️ @videojs/react
Presets (7)
Media (8)
Skins (27)
UI Components (30)
Sizes are marginal over the root entry point. 🧩 @videojs/core
Entries (10)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3bbb041. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The slider focus stuff is because if we don't suppress announcements when the sliders have focus, we get double upped announcements.
Closes #1436
Validation
Notes
Note
Medium Risk
Touches live-region accessibility and focus behavior across React/HTML/custom elements; logic is well-tested but incorrect suppression or timing could affect screen-reader UX.
Overview
Adds snapshot-driven screen-reader announcements in
StatusAnnouncerCore: confirmed changes to play/pause, captions (when available), fullscreen, PiP, and playback rate are announced immediately; volume and completed seeks are debounced (200ms) and ignore normalcurrentTimedrift. React and HTMLStatusAnnouncercomponents now subscribe to the player store (with baseline/reset on reconnect) and render visually hidden live-region text instead of drivingaria-labelfrom input actions alone.Seek/volume suppression when a
role="slider"inside the player container has focus avoids doubling slider-owned feedback;getMediaSnapshotnow includesplaybackRateandseeking. Player containers get shared defaults (role="group",aria-label,tabindex) viaapplyContainerAttrs/ ReactContainer, and pointer-up focus uses composed-tree active-element helpers for shadow DOM.Reviewed by Cursor Bugbot for commit a502337. Bugbot is set up for automated code reviews on this repo. Configure here.